Skip to content

TML-2597: SQL ORM many-to-many — project spec + plan#673

Open
tensordreams wants to merge 1 commit into
tml-2729-sql-orm-drop-lateral-for-includes-in-favour-of-correlatedfrom
tml-2597-sql-orm-complete-end-to-end-many-to-many-support-include
Open

TML-2597: SQL ORM many-to-many — project spec + plan#673
tensordreams wants to merge 1 commit into
tml-2729-sql-orm-drop-lateral-for-includes-in-favour-of-correlatedfrom
tml-2597-sql-orm-complete-end-to-end-many-to-many-support-include

Conversation

@tensordreams
Copy link
Copy Markdown
Contributor

Shaping artifacts for the SQL ORM: Many-to-Many End to End project. No code changes — projects/sql-orm-many-to-many/ only (spec, plan, README, trace).

Stacked on #667 (TML-2729, correlated-only read path). Review/merge that first; this PR is based on its branch, not main.

What this adds

  • spec.md — system-level intent: restore the relation-shaped ORM API (include / filter / nested write) over M:N, so users stop hand-wiring explicit junction models and the Pothos plugin stops rejecting M:N at build.
  • plan.md — 4 slices: slice 0 (contract + resolver foundation) gates a parallel fan-out of read / filter / write.

Key decisions captured

  • The ticket was stale. Its Phase 1/2 (LATERAL path, multi-query fallback) were deleted by TML-2729: drop LATERAL include codegen for correlated-only read path #667 (TML-2729) and TML-2657. The work now extends the correlated builder; there is no LATERAL or fallback path to teach.
  • Surprise found while shaping: an emitted M:N contract does not validate today — the relation validator rejects cardinality: N:M and the undeclared through key. Slice 0 closes that; it is a real gap, not prep.
  • Representation: a uniform through descriptor on the single shared resolver, consumed three ways (not junction-as-nested-include, which does not generalise to filter/write).
  • Scope: write vocabulary is the three kinds that exist (connect/disconnect/create); nested update/upsert/delete/set are out of scope → TML-2781.

Linear

Promoted from TML-2597 to a dedicated Linear Project (SQL ORM: Many-to-Many End to End). Slices: TML-2784 (0) / TML-2785 (1) / TML-2786 (2) / TML-2787 (3).

Scope statement

Planning artifacts only. No package code, no fixtures, no behavior change. Refs: TML-2597.

Shape the end-to-end many-to-many project: spec + 4-slice plan
(0 contract+resolver foundation, gating parallel read/filter/write).
Promoted from TML-2597 to a dedicated Linear Project; slices
TML-2784..2787. No code changes — planning artifacts only.

Signed-off-by: Alexey Orlenko's AI Agent <robot@aqrln.net>
@tensordreams tensordreams requested a review from a team as a code owner June 1, 2026 16:26
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 55352d88-31d5-423e-aeae-1aac70c866fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tml-2597-sql-orm-complete-end-to-end-many-to-many-support-include

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant